fix: ObjectDisposedException on NetworkManager after shutting down the Transport #3142
+65
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that
UnityTransport
is marked asDisconnected
after shutting down. This ensures that no exceptions are thrown when trying to use the transport after it has been shut down.This PR also adds a warning message when a
UnityTransport
has aNetworkManager
andUnityTransport.Shutdown()
has been called outside ofNetworkManager.Shutdown()
as shutting down theUnityTransport
directly will result in unexpected disconnection behaviour (connected clients will not getDisconnect
events and pending messages may be dropped).fix: #3118
Changelog
ObjectDisposedException
was thrown when callingNetworkManager.Shutdown()
after callingUnityTransport.Shutdown()
Testing and Documentation
UnityTransportTests
to ensure exceptions are not thrown when using the transport after shutting it down.